Skip to main content

Wade Armstrong

Sample Code Review Checklist #

For the Developer #

Developing Good Code #

Before You PR #

A good code review starts with a good pull request. Before you find yourself a reviewer for your code, make sure:

If you haven't done all of the above, then you won't get a code review -- your work will just get kicked back to you. Spend your time, and your reviewer's time, well, and do all of these first. Ask for help if you need it.

After You Open Your PR, but Before You Get a Reviewer #

Getting a Reviewer #

For the Reviewer #

Before You Review #

Early Returns are Good, Even In Code Review #

If any of the below are true, mark the code as Needs Work and bounce it right back:

Giving Good Code Review #

Further Reading #